Skip to content

rename period_data back to stress_period_data - #546

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:stress-period-data
Nov 6, 2026
Merged

wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:stress-period-data

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Undo #540's rename, a stress period is MODFLOW's unit of time, not a concept specific to stress packages

A stress period is MODFLOW's unit of time, not a property of stress
packages, so STO's and OC's per-period settings are stress period data
too. The name also matches MF6's term and flopy3's keyword, and the
DFNs, which keep it, so codegen no longer maps it.

This undoes modflowpy#540's rename, field and class names alike. External list
files are <model>_<pkg>_stress_period_data_p<n>.<ext> again, and generated
code, grammars and snapshots match those from before modflowpy#540.

stress_period_data is no longer a legacy alias, since it's the field.
flopy3's other names (perioddata, lakeperioddata, ...) stay aliases as
modflowpy#541 made them, and STO's and OC's attribute errors now point to
stress_period_data. The kper dims from modflowpy#543 are unaffected.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@wpbonelli wpbonelli added this to the MMP milestone Nov 6, 2026
@wpbonelli
wpbonelli merged commit 5b2d3bc into modflowpy:develop Nov 6, 2026
18 checks passed
@wpbonelli
wpbonelli deleted the stress-period-data branch November 6, 2026 00:12
wpbonelli added a commit to wpbonelli/pyphoenix-project that referenced this pull request Nov 6, 2026
… develop

STO's value in these 37 is one word per period again. Against this branch
before the rebase, they differ only by modflowpy#546's names.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
wpbonelli added a commit to wpbonelli/pyphoenix-project that referenced this pull request Nov 6, 2026
Record D5's reversal in the audit, and use the name throughout the plans.
With the field and flopy3's name the same on most stress packages, the
period-list values plan loses its argument for a legacy-only subclass.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant